Repository navigation
feat(router): dispatch explicit HEAD routes before GET fallback - #189
Merged
Merged
Conversation
Owner
Author
Verification verdictPASS+NOTES from the implementing assistant's sequential review fallback. This is not an independent review. The session has no subagent tool. Reviewed head
Remote CI must finish successfully at this head before merge. Router-generated HEAD error bodies remain unchanged. Normalizing all error bodies is outside this ticket. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #166. Queue clients keep the same HEAD behavior. Maintainers can register Peek directly instead of checking the HTTP method inside Dequeue.
The change covers explicit HEAD priority and body removal. It preserves existing
Allowvalues. Extra HTTP methods and middleware changes are out of scope.Evidence
11 passed | 7 failedbecauseRouter.headis absent. Adding registration alone still leaves six dispatch tests failing.After:
deno test --frozen tests/router_test.tsreports18 passed | 0 failed. Router and unchanged handler tests together report162 passed | 0 failed.Allow: GETfor an unsupported Dequeue method.After: A live HTTP comparison passes all 16 requests on both production binaries with identical results, including FIFO Dequeue and empty-Queue responses.
deno test --frozen --allow-read --allow-write --allow-net --allow-env --allow-runreports390 passed | 0 failed, including Docker persistence and the real Stryker runner.npm run quality:productionpasses. CI is green for Test, Production quality, Mutasaurus, and Stryker.Merge Danger
Door: two-way
A code revert restores the old dispatch. No stored data or configuration changes.
Blast Radius: routing
HEAD dispatch changes inside Router. GET fallback, authentication, Queue preservation, and existing method-error headers have regression coverage.