Repository navigation
ui: fall back to own conversations when useAgentInstances(true) is refused - #3288
Open
suryakant-source wants to merge 2 commits into
Open
suryakant-source wants to merge 2 commits into
suryakant-source wants to merge 2 commits into
Conversation
useAgentInstances(true) now re-reads with allCreators: false when the wide read is refused (403) and exposes widerReadRefused, matching useAgentConversations. Signed-off-by: Suryakant Sahoo <[email protected]>
Signed-off-by: Suryakant Sahoo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3212
useAgentInstances(true)surfaced the controller'sPermissionDeniedforall_creatorsas a page error, soAgentsPageshowed "Could not count conversations" andUnmappedConversationsPagefailed for callers without that permission.The hook now re-reads with
allCreators: falsewhen the wide read is refused (403) and exposeswiderReadRefused, the same wayuseAgentConversationsalready does. Other errors are still reported as errors. The return type gains an optionalwiderReadRefused; existing callers keep working unchanged.Tests: added
useAgentInstances.test.tsxcovering the allowed wide read, the 403 fallback, a non-403 failure, and the narrow read.vitest,tsc --noEmitand eslint pass on the changed files.Commits are signed off (DCO).