Repository navigation
fix(security): update runtime certificate trust in v0.10.x - #3320
Open
rtemperini wants to merge 3 commits into
Open
rtemperini wants to merge 3 commits into
rtemperini wants to merge 3 commits into
Conversation
Signed-off-by: rtemperini <[email protected]>
rtemperini
requested review from
a team,
Charlesthebird and
peterj
as code owners
October 22, 2026 12:24
github-actions
Bot
added
bug
EItanya
reviewed
Oct 22, 2026
Signed-off-by: rtemperini <[email protected]>
github-actions
Bot
added
bug
moezdil
reviewed
Oct 23, 2026
| ### STAGE 1: Dependencies and Build | ||
| ARG BASE_IMAGE_REGISTRY=cgr.dev | ||
| ARG TOOLS_NODE_VERSION=24 | ||
| ARG TOOLS_NODE_VERSION=24.22.1 |
Contributor
There was a problem hiding this comment.
could we avoid pinning the exact nodejs patch version?
moezdil
reviewed
Oct 23, 2026
| # Use distroless as minimal base image to package the manager binary | ||
| # Refer to https://github.com/GoogleContainerTools/distroless for more details | ||
| FROM gcr.io/distroless/static:nonroot | ||
| FROM gcr.io/distroless/static-debian13:nonroot@sha256:d62067879de890a1def9da0e7766b7d20810a5e5555cef8506b752437d7a3e88 |
Contributor
There was a problem hiding this comment.
could the static-debian13 swap be mentioned in the description?
Signed-off-by: rtemperini <[email protected]>
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3310. The Go verifier fix does not update the independent trust stores used by Python, uv, Node, or git/curl. The published
0.10.4ADK image still accepts the affected roots in its system store, certifi, and ensurepip wheel.gcr.io/distroless/static:nonrootGo runtime base withgcr.io/distroless/static-debian13:nonroot@sha256:d62067879de890a1def9da0e7766b7d20810a5e5555cef8506b752437d7a3e88for the controller and Go ADK. The pinned Debian 13 base has the corrected CA bundle; its AMD64 and ARM64 bundles were verified.20250419+deb13u1in the Trixie builder and20250419~deb12u2in the Bookworm full image.GRPC_DEFAULT_SSL_ROOTS_FILE_PATHsetting. Its upstream roots fix has no published wheel yet. No certificate files are filtered or patched.Local validation: the published
kagent-adk:0.10.4image retains affected CA trust. Rebuilt ARM64 slim/full and AMD64 slim images pass the five local trust checks. The rebuilt system, certifi, and botocore bundles each reject all 12 published compromised chains offline (36 checks). Lockfile checks, Python lint, andgit diff --checkpass.This needs a new release and rollout of rebuilt images. Inactive bundled gRPC/httplib2 fallback files remain upstream-owned; these updates address effective trust and do not remove every bundled PEM. Full application tests and vulnerability scans were not run locally.
References: incident and fixed versions, uv 0.13.5, certifi, botocore.
Main-branch counterpart: #3321.