Repository navigation
fix(proton): let empty-trash start its pipeline in the image - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
task empty-trash(host side, asks first) runstask op -- task empty-trash-pipeline. Inside the image that is a command-line call, and go-task refuses an internal task there ("Task "empty-trash-pipeline" is internal", verified on 3.53.1 in the image and 3.54.0 on the host). Sotask empty-trashcould not work in github. Found during C8; the owner approved fixing it in v2.6.0. dropbox has its own copy, fixed in its phase 4 PR.empty-trash-pipelineis no longer internal; a comment says why. It has nodesc, so it stays out oftask --list.offlineproves the name starts from the command line (task --dry empty-trash-pipeline). Withinternal: trueput back,offlinefails (exit 201).internalwas never a permission boundary (task op -- <cmd>runs anything in the image with the secrets), and CI cannot name a task (validate-vars.sh refuses any word that is not KEY=value).Test plan
task run -- task offlineandtask checkin examples/protoninternal: truerestored -> offline failspipeline's dry render byte-identical, so no consumer's render.txt moves