Repository navigation
ChaCha20 over unboxed words, proved equal to the RFC block - #58
Merged
Merged
Conversation
… and XOR in ByteArrays
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChaCha20 was the largest single cost left in huh's QUIC transfers (about a quarter of each process's CPU in
quarterRound), plus allocation from building the keystream.ChaCha20.blocknow keeps the 16-word state in the unboxed fields of a structure instead of anArray UInt32updated withset!. The previous definition stays asblockSpec, andblock_eq_specproves the two equal (axioms: propext, Classical.choice, Quot.sound).ChaChaPoly's keystream is appended in place into one preallocatedByteArray, and the XOR isByteArray.ofFnover the two byte arrays, instead of round trips throughArray UInt8(ByteArray.dataandByteArray.mkboth copy).size_chacha20andchacha20_chacha20are re-proved over the new XOR.chacha20 blockandchacha20 block, spec.Growth is linear (3.7×, 4.0×, 4.0× per 4× size).
make testpasses, including 316/316 Wycheproof ChaCha20-Poly1305 vectors and the ChaCha20 keystream vectors.