Repository navigation
docker: use main branch for cvehound - #3242
Merged
Merged
Conversation
The cvehound repository uses main as its default branch and no longer has a master ref. Update the pip install URL to fix the Docker image build failure. Signed-off-by: Denys Fedoryshchenko <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cvehound image build fails because pip tries to check out
master, which no longer exists in the upstream repository. Change the install URL to@mainso the checkout uses the current development branch.Validation:
python3 -m pytest tests/test_configs.py: 33 passed.make validate-yaml: 19 rootfs configurations validated../kci docker generate cvehound kernelci: rendered successfully and uses@main.git diff --check upstream/main...HEAD: passed.make test: blocked becausemypyis not installed.A full Docker image build was not run.