Repository navigation
Conversation
) setup.py asked for numpy>=1.22.2 and meshpy>=2018.2.1, so pip installed microstructpy 1.6.0 with numpy 2.5 and MeshPy 2026.1, while the continuous integration installs requirements.txt, which pins numpy below 2 and MeshPy 2022.1.3. With those newest versions, 13 of the 224 tests fail. With numpy 2, the text files of the meshes cannot be read back (numpy writes integers as np.int64(4)) and tangent_sphere fails. With MeshPy 2026, TetGen lets 3D elements exceed max_volume. setup.py now asks for numpy<2 and meshpy<2026. Installed that way, pip takes numpy 1.26.4 and MeshPy 2025.1.1 (2022.1.3 on Python 3.9), and all 224 tests pass. numpy below 2 has no wheels for Python 3.13 and later, but pip builds it from source there; on Python 3.14 that takes under a minute, and all the tests pass. One more CI job, Python 3.12 on Ubuntu, skips requirements.txt and installs the package alone, as pip install microstructpy does, so that the tests see the dependency versions that users get. It does not upload coverage, which the pinned job of the same Python and system already reports. Suggested by Kip Hart in the review. The changelog has a 1.6.1 section, __version__ is 1.6.1, and the example digest of the documentation is updated. Co-Authored-By: Claude Opus 5.5 <[email protected]>
kip-hart
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
developtomasterfor the 1.6.1 release. The only change since 1.6.0 is #120:setup.pycaps numpy below 2 and MeshPy below 2026, the versions the package works with. A plainpip install microstructpy==1.6.0resolves numpy 2.5 and MeshPy 2026.1, and 13 tests fail with them.requirements.txt, as users install the package.As with #114, this should be merged with a merge commit, so that
masterkeepsdevelop's history. After the merge, Kip tags v1.6.1 onmaster, which publishes it to PyPI, and yanks 1.6.0.🤖 Generated with Claude Code