Repository navigation
fix(nz/ird): raise the upper limit to 200,000,000 - #266
Merged
Merged
Conversation
Inland Revenue raised the maximum valid IRD number from 150,000,000 to 200,000,000 in February 2026. python-stdnum still caps at 150,000,000, so this is a deliberate difference. Fixes #265
2 of 32 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises the
nz/irdupper limit from 150,000,000 to 200,000,000.The range check added in #254 copied python-stdnum's
10000000 < n < 150000000. Inland Revenue announced on 10 February 2026 that the maximum valid IRD number increases to 200,000,000: https://www.ird.govt.nz/updates/news-folder/2026/increase-to-ird-number-validation-upper-limitpython-stdnum master still uses 150,000,000, so this is now a deliberate difference (doc comment updated; noted on #91).
Tests
150000009and199-999-990(made-up, valid check digits) are now accepted; both fail without the fix (verified by settingird.tsaside and rerunning the spec).200000005(valid check digit) is rejected withInvalidComponent.calc_check_digit.npm test(4717 passed),npm run lint,prettier --checkpass.Not verified
Fixes #265