Repository navigation
fix(nl/btw, se/personnummer): return invalid for empty input instead of throwing - #269
Merged
Merged
Conversation
…of throwing
validate('') threw a TypeError in both validators. clean() destructured
strings.splitAt(), which drops empty parts, so the first part was
undefined for an empty (or very short) value. Use plain slices there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #268
stdnum.NL.btw.validate('')andstdnum.SE.personnummer.validate('')threw aTypeErrorinstead of returning an invalid result. The same happened throughvalidateVat('NL', ''),validateEntity('NL', '')andvalidatePerson('SE', '').Both
clean()functions destructuredstrings.splitAt().splitAtdrops empty parts, so for an empty value the first part wasundefined. The fix uses plainslicecalls there. For any value long enough to fill every part, the result is the same as before.Tests: a
validate:emptycase innl/btw.spec.tsandse/personnummer.spec.ts. Both fail onmainwith theTypeErrorand pass with the fix.npm testpasses (4719 tests) and so doesnpm run lint. I also ran every validator on ~4000 random short strings each. Nothing else throws.