Repository navigation
fix(nz/ird): format 9-digit numbers as nnn-nnn-nnn - #271
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
format()splits every IRD number after the 2nd and 5th digit, so a 9-digit number comes out as04-909-1850instead of049-091-850. Every number from 100,000,000 up has 9 digits, and so does the zero-padded form of an 8-digit one. The OECD TIN sheet cited in the module gives the format as "99-999-999 or 999-999-999" (Section II), and python-stdnum returns049-091-850.9-digit numbers are now split after the 3rd and 6th digit. 8-digit numbers and other lengths format as before. The
formatspatterns, generated from the old output in #258, now listnnn-nnn-nnninstead ofnn-nnn-nnnn.