Repository navigation
Handle Podlove chapters without start times - #604
Open
terminalchai wants to merge 1 commit into
Open
terminalchai wants to merge 1 commit into
terminalchai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Podlove Simple Chapters element without a
startattribute makesfeedparser.parse()raiseTypeError, including the minimized<psc:chapters<psc:chapter>input in #599 and otherwise well-formed RSS and Atom feeds.Return
Nonefor an absent start time, matching the existing treatment of empty or invalid start strings. Chapter metadata and valid surrounding chapters are preserved.Addresses the missing Podlove chapter start case in #599, rather than closing the entire malformed-feed report. Adds a changelog fragment and 13 test cases covering the reported input, RSS and Atom, strict and fallback parsing, and missing/empty/invalid start values.
Validation on Windows with Python 3.11:
TypeError; 8 compatibility cases passed. After the fix: all 13 pass.git diff --checkpass.Prepared with AI assistance; the diff and test results were reviewed before submission.