Repository navigation
Generate format_presets from a namedtuple spec - #259
Open
rtibblesbot wants to merge 2 commits into
Open
rtibblesbot wants to merge 2 commits into
rtibblesbot wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
rtibblesbot
force-pushed
the
issue-185-140e1c
branch
from
November 5, 2026 04:31
0799be7 to
ffec48d
Compare
rtibblesbot
marked this pull request as ready for review
November 5, 2026 04:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
le_utils/constants/format_presets.pyand newjs/FormatPresets.jsare generated fromspec/constants-format_presets.json.le_utils/resources/presetlookup.jsonis deleted.lists(forRENDERABLE_PRESETS_ORDER) andlabel_constant_suffix(for_READABLEconstants) spec options.References
Closes #185. Spec format: #182.
Reviewer guidance
Suggested review: Full code review, then manual QA once the reviewer sets Needs QA.
js/FormatPresets.js.RENDERABLE_PRESETS_ORDERlisted explicitly in the spec, guarded only by a test, is the bitmask contract later migrations should copy.kolibri-constants/FormatPresetsshould export the 33 English_READABLElabels and omitRENDERABLE_PRESETS_ORDERandchoices.AI usage
Used Claude Code to add the generator options, build the spec from the existing module and JSON, and write the tests. Verified with the full test suite, prek, and a repeated
make buildleaving no diff.Written by rtibblesbot, an LLM-based coding agent.
🟡 Waiting for feedback
Last updated: 2026-11-05 04:34 UTC