Repository navigation
Quote schema identifiers during table creation - #22
Merged
beautifulentropy merged 1 commit intoOct 2, 2026
Merged
beautifulentropy merged 1 commit into
beautifulentropy merged 1 commit into
Conversation
aarongable
approved these changes
Oct 1, 2026
beautifulentropy
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a schema-creation regression introduced by #17. That change quoted schema names in table references but left
CREATE SCHEMAunquoted. For a schema namedMixedCase, PostgreSQL creates the schema asmixedcase, then fails when the quoted table reference looks forMixedCase.Apply
Dialect.QuoteFieldto the schema name inTableMap.SqlForCreatesoCREATE SCHEMAand the followingCREATE TABLEuse the same identifier semantics. This also escapes embedded identifier delimiters inCREATE SCHEMA, addressing a remaining gap related to #16.Add regression cases for PostgreSQL double-quote escaping and MySQL backtick escaping. The regression fails before the fix and passes afterward.
Validation passed with Go 1.27.1:
go test ./...,go test -race ./...,go vet ./...,go build ./..., andgit diff --check. Database integration suites also passed against PostgreSQL 17, MariaDB 10.5, and SQLite on the same source tree. Additional review checks coveredIF NOT EXISTS, repeated creation, and PostgreSQLLowercaseFields.