Repository navigation
Combined pages always name their resources - #115
Merged
Merged
Conversation
A source page without /Resources, even inherited, was copied without any: qpdf 12.4 now warns and repairs it, which fails test_combined_pages_never_write_infinite_numbers. Assisted-by: Claude Opus 5.5 [Claude Code]
czj
enabled auto-merge (squash)
November 19, 2026 12:19
czj
added a commit
that referenced
this pull request
Nov 19, 2026
A screen reader reads the PDFs Gamba writes glyph by glyph, in drawing order: no headings, no tables, no language. #110 gave every native box a role; nothing read them yet. `pdf: :ua` writes PDF/UA-1 and `pdf_a: :a` PDF/A-3a, alone or together, tagging the native boxes from their roles. Part of #76: the Prawn API's `tag` and `artifact` blocks, `ActualText` for ligatures and the cost on the benchmarks page come next. - **Structure from roles**: headings, paragraphs, lists, figures with their `alt`, and tables with column header cells, in the order boxes are placed. A paragraph or a table across pages stays one element; `lang:` on any box sets its language. - **Artifacts**: headers and footers (pagination artifacts), backgrounds, borders, page backgrounds, and the copy of a table's header atop later pages. - **Rules raised where broken**: a font not embedded (imported pages included), a figure without `alt`, a list item outside a list, anything drawn through `document.prawn`, and under `pdf: :ua` no `lang`, no title or a skipped heading level, raise `PdfUaViolation` (`PdfAViolation` under `pdf_a: :a` alone). In both modes, the default style's font is also the document's, looked up when first used, since Helvetica cannot be embedded. - **Declared changes**: in a tagged document, links and annotations raise, since Gamba does not tag them yet. `pdf_a:` now accepts only `true`, `false`, `nil`, `:a` and `:b`, and raises on anything else. - **Known limits**: a tagged document refuses to import a page with marked content of its own. The check reads the page's content streams, not its form XObjects. It errs on the side of refusing: optional-content layers (`/OC … BDC`), and text that happens to contain `BDC` or `BMC` as a word, count as marked content. - **Tagged where placed**: containers and the document tag a box when they place it (`flow_tagged`, `paint_tagged`), one `tagged?` check when untagged. A module prepended to every box class did it at first, and TruffleRuby skipped it. - **veraPDF in CI**: the PDF/A tests skipped in CI until now. CI installs veraPDF 1.30.4 (SHA-256 pinned, PGP signature checked), and a missing veraPDF fails there instead of skipping. - **Nothing else moves**: an untagged or PDF/A-3b document has the same bytes as on `main`, and tagged pages are pixel-identical to untagged ones with the same default font. <details><summary>Proof</summary> - `test/tagging_test.rb`: veraPDF passes `ua1` and `3a` on a report (headings, a paragraph and a decorated stack across pages, lists, a figure, an 80-row table, a header, a French paragraph) under each mode and both together, and on the three `bench/native` documents tagged. qpdf reads back the structure tree, one paragraph and one table across pages with its header once, balanced marked content and MCIDs matching the ParentTree on every page, and the catalog and XMP. MuPDF renders tagged and untagged pages identically, also when a decorated stack moves to the next page before drawing. Tables in a figure and in a cell, and each raised rule, are covered too. - The layout fuzzer also runs a quarter of its trees as PDF/UA and checks every page's marked content. Its 250 tagged trees of seed 99 pass, and 26 trees from other seeds pass veraPDF `ua1`. - Untagged PDF and PDF/A-3b with Factur-X are byte-identical to `main`. `bench/native`, median of 15, no JIT then YJIT: report 385 / 303 ms on `main` against 388 / 309 ms here; catalog with YJIT interleaved 5 times 251 against 262 ms, within the noise of either side (237 to 278 ms). Same bytes, +0.1 % allocations (the `lang` slot). - CI green on every Ruby, TruffleRuby included, with veraPDF installed: 1405 runs. `test_combined_pages_never_write_infinite_numbers` failed here with the newer qpdf this workflow change pulled in; #115 fixed that on `main`, merged into this branch. RuboCop and the highlighted docs are clean. </details> --------- Co-authored-by: Clément Joubert <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gamba.combine copied a page without /Resources as it was, even though ISO 32000-1 requires them, empty or inherited. qpdf 12.4 now warns about such a page and repairs it, so
test_combined_pages_never_write_infinite_numbersfails on a Mac with current Homebrew tools, and in CI once its package cache refreshes (it does on #114).A copied page with no resources of its own or inherited now gets an empty dictionary, as pages Gamba draws already do.
Proof
test_combined_pages_never_write_infinite_numbersfails on main and passes here.rake testwith the corpus fetched: 1387 runs, 0 failures. RuboCop clean.