Repository navigation
👷 v5: Build unit tests without ASan - #112
Merged
Merged
Conversation
libhal-cmake-util v4 builds the unit tests with AddressSanitizer whenever the compiler supports it, and LLVM 20's ASan runtime deadlocks before main() on macOS 26+. CI's Mac job now runs on macOS 26, so the v5 package check hangs there until it is cancelled. Define the result of cmake-util v4's ASan compiler check as false, which turns ASan off for this old-generation package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns off AddressSanitizer for the
v5/unit tests.libhal-cmake-util v4 builds them with ASan whenever the compiler supports it, and LLVM 20's ASan runtime deadlocks before
main()on macOS 26+. Since the shared Mac job moved tomacos-26(libhal/ci#127), thev5/package check hangs there until cancelled: it ran 63 minutes on #107.cmake-util v4 has no option for this, so
v5/CMakeLists.txtdefines the result of its ASan compiler check (ADDRESS_SANITIZER_SUPPORT) as false before callinglibhal_unit_test(). v5 is old-generation code, so losing ASan there is acceptable.Testing
macOS 27 with LLVM 20 (the combination that deadlocks): the build reports ASan disabled, and the tests run and pass.