Skip to content

Drop fence passing and rebase on a 6.12.111 kernel - #152

Closed
slp wants to merge 2 commits into
libkrun:mainfrom
slp:drop-fence-passing
Closed

slp wants to merge 2 commits into
libkrun:mainfrom
slp:drop-fence-passing

Conversation

@slp

@slp slp commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

slp added 2 commits October 1, 2026 10:56
Was never really used, and defines an ID that collides with another one
already merged upstream.

Signed-off-by: Sergio Lopez <[email protected]>
Rebase on the latest 6.12.x LTS. No changes needed in the downstream
patches.

Signed-off-by: Sergio Lopez <[email protected]>

@jakecorrenti jakecorrenti left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't speak to the DRM patches, but LGTM otherwise

@slp

slp commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator Author

@jakecorrenti oops... forgot to close this one, that has been superseded by #155, sorry about htat.

@slp slp closed this Nov 4, 2026
@s0ullight

Copy link
Copy Markdown

Is there maybe a different path forward? While currently unused, fence passing could help quiet a bit with performance gains.

HoneyKrisp's implicit sync under virtio is leaving a lot of performance on the table. I've been foolishly experimenting with relaxing the sync (see here). Any variation of that unfortunately seems to be a hack at best.

@slp

slp commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator Author

Is there maybe a different path forward? While currently unused, fence passing could help quiet a bit with performance gains.

We dropped the patch because it was never merged upstream (and another feature was colliding with its ID), and nothing was making use of it in userspace.

If there's another take at fence passing, we'll be happy to carry the patch here.

@s0ullight

Copy link
Copy Markdown

Great to hear you're willing to carry the patch downstream. I have something working, but maybe let's settle on a different bit to resolve the conflict before I send a PR?

@slp

slp commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator Author

Great to hear you're willing to carry the patch downstream. I have something working, but maybe let's settle on a different bit to resolve the conflict before I send a PR?

It's okay, we switched from downstream patches to fetching a branch precisely to make easier to accept contributions. You can open a PR against this branch: https://github.com/libkrun/linux/tree/libkrunfw-linux-6.12.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants