Repository navigation
fix(ci): count Dock tiles in the macOS end-to-end, not applications - #942
Merged
Merged
Conversation
…the dock The dock tests settled while the review panel still showed Loading: its diff arrives from a goroutine, and the rig's virtual clock settles in microseconds. On a slow runner the read landed between the click's frames, which then differed for a reason the click never caused. The test asserted a frame the contract never promised; it now waits for the panel's read first. With the fake backend's diff reply delayed 0.5-1ms the two tests failed 9 of 800 runs before, 0 of 800 after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #932 the backend is an AppKit application with the accessory activation policy, so its menu-bar item can exist.
lsappinfonow lists it inLich.appas aUIElementbeside the window, aForegroundapp, andone_appcounted both: the v0.79.0 release failed on both Macs with "macOS counts 2 applications in Lich.app". The e2e runs only inrelease.yml, so #932 never met it.The contract changed in #932, so the check follows it: what it guards, per its own comment, is a second Dock tile.
one_appnow counts theForegroundentries inLich.app(one, the window) and checks the backend is aUIElement, so a backend that takes a Dock tile of its own still fails.Also fixes the flake that failed this PR's
macoscheck:TestDockFullScreenFillsTheRowInTheFrameAfterTheClicksettled while the review panel still showed Loading, and its diff read, from a goroutine, landed between the click's frames. Both dock tests nowwaitForthe panel's first read. The test asserted a frame the contract never promised.Test plan
one_apprun against thelsappinfooutput from the failed run: passes; with the backend turnedForegroundit fails (2), with the window gone it fails (0).release.ymldispatched on this branch: both mac jobs green (the release job is tag-only).