Terminate log macro calls used as expressions - #1123
Merged
Merged
Conversation
Rust 1.99 warns about trailing semicolons in macros from other crates when the macro is used in expression position. LDK's log macros expand with a trailing semicolon, so calls at the end of a block or as a match arm now fail the build under -D warnings. Terminate those calls explicitly. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
I've assigned @tnull as a reviewer! |
tnull
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust 1.99 warns about trailing semicolons in macros from other crates when the macro is used in expression position. LDK's log macros expand with a trailing semicolon, so calls at the end of a block or as a match arm now fail the build under -D warnings. Terminate those calls explicitly.
only needed to fix CI until https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/pulls/5053