Skip to content

[improvement] change the subnet-name cache to include the VPC ID in the subnet key - #664

Open
AshleyDumaine wants to merge 1 commit into
mainfrom
subnet-name-cache
Open

AshleyDumaine wants to merge 1 commit into
mainfrom
subnet-name-cache

Conversation

@AshleyDumaine

@AshleyDumaine AshleyDumaine commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Rationale

We want to avoid potential cache collisions by keying off both the VPC ID and the subnet name, not just the subnet name. This is relevant for NodeBalancers provisioned in the same cluster but using different VPCs via annotations.

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@github-actions github-actions Bot added the improvement for improvements in existing functionality in the changelog. label Nov 18, 2026
@codecov

codecov Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.73%. Comparing base (e3294d3) to head (d874cf2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #664      +/-   ##
==========================================
+ Coverage   82.65%   82.73%   +0.07%     
==========================================
  Files          19       19              
  Lines        2618     2629      +11     
==========================================
+ Hits         2164     2175      +11     
  Misses        454      454              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AshleyDumaine
AshleyDumaine marked this pull request as ready for review November 18, 2026 20:53
@AshleyDumaine
AshleyDumaine requested review from a team as code owners November 18, 2026 20:53
@AshleyDumaine
AshleyDumaine enabled auto-merge (squash) November 19, 2026 19:19

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement for improvements in existing functionality in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant