Skip to content

TPT-4708: Expose NodeBalancer backend IPv6 prefix - #745

Merged
lgarber-akamai merged 1 commit into
linode:devfrom
zliang-akamai:tpt-4708-nodebalancer-backend-ipv6-prefix
Sep 30, 2026
Merged

lgarber-akamai merged 1 commit into
linode:devfrom
zliang-akamai:tpt-4708-nodebalancer-backend-ipv6-prefix

Conversation

@zliang-akamai

Copy link
Copy Markdown
Member

📝 Description

Expose the system-assigned backend_ipv6_prefix returned on NodeBalancer resources, so callers can use it when configuring inbound firewall rules for IPv6 backends. Cover populated and null values and confirm the read-only prefix is not sent in create or update requests.

The /backend_acl endpoint is not available yet and is intentionally excluded from this PR.

✔️ How to Test

python -m pytest test/unit/objects/nodebalancers_test.py test/unit/linode_client_test.py -k 'backend_ipv6_prefix or test_get or test_type_and_backend_connectivity_not_in_put or test_create_with_ipv6_backend_connectivity'

22 passed, 76 deselected. The added integration assertion was not run against the live API.

@zliang-akamai
zliang-akamai requested review from a team as code owners September 28, 2026 18:10
@zliang-akamai
zliang-akamai requested review from lgarber-akamai and psnoch-akamai and a lite review from Copilot and removed request for a team September 28, 2026 18:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Create requests can still forward a caller-supplied read-only backend_ipv6_prefix.

Review effort: Lite
Findings: 1 Medium severity

Open (1)
What changed in this PR

Exposes the system-assigned, read-only backend_ipv6_prefix on NodeBalancer resources.

Changes:

  • Adds the model property and populated/null fixture coverage.
  • Adds unit and integration tests for retrieval and update omission.
  • Create requests still require filtering or rejecting caller-supplied backend_ipv6_prefix.
File Description
test/​unit/​objects/​nodebalancers_test.py Tests populated, null, and update behavior.
test/​unit/​linode_client_test.py Tests create response handling and request exclusion.
test/​integration/​models/​nodebalancer/​test_nodebalancer.py Validates the returned value type.
test/​fixtures/​nodebalancers.json Adds populated and null values.
test/​fixtures/​nodebalancers_123456.json Adds the populated prefix.
test/​fixtures/​linode_instances_123_nodebalancers.json Adds the prefix to nested data.
linode_api4/​objects/​nodebalancer.py Adds the read-only property.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread test/unit/linode_client_test.py

@lgarber-akamai lgarber-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@lgarber-akamai
lgarber-akamai merged commit e35b61d into linode:dev Sep 30, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants