Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes for the yt-dlp section of the preferences.
Switch layout
The "Use local version"
GtkSwitchhas no alignment set, so the grid stretches it to fill its cell, which makes it oversized. It is now alignedvalign=CENTER,halign=START, so it keeps its natural size next to its label.UI freeze while updating yt-dlp
update_ytdlp()runsyt-dlp --update, orwgeton first use, synchronously on the GTK main thread. The window freezes for as long as the download takes, or indefinitely on a slow or stalled connection.It now runs through the existing
@async_functiondecorator. The version label is updated withGLib.idle_add, so the widget is only touched from the main thread.