Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for the "Add to favorites" star button on the channel page.
Wrong icon name
When a channel is removed from favorites, the icon is set to
non-xsi-starred-symbolic, which doesn't exist. The button loses its icon. Nowxsi-non-starred-symbolic, the name already used inbefore_play().Stale tooltip
The tooltip was only set when a channel started playing. After toggling the star it kept saying "Add to favorites" / "Remove from favorites" from before the click. It is now updated on toggle.
Crash when no channel is active
active_channelisNoneat startup and after Stop. Toggling the button then raisedAttributeErroronself.active_channel.name. The handler now returns early in that case.Lookup tolerant of extra fields
before_play()matched a favorites line exactly againstinfo:::url. It now also accepts lines that start withinfo:::url:::. Existing favorites files behave the same. This lets later changes append extra fields to a favorites line, e.g. EPG metadata, without the star losing track of the channel.