fix(rtc): deliver buffered frames and end iteration at end of stream - #836
Closed
RaphaelFakhri wants to merge 2 commits into
Closed
RaphaelFakhri wants to merge 2 commits into
RaphaelFakhri wants to merge 2 commits into
Conversation
RaphaelFakhri
requested review from
changt,
cloudwebrtc,
lukasIO and
xianshijing-lk
as code owners
September 29, 2026 10:19
Author
|
Confirmed. With a bounded queue, the end-of-stream Fixed in a122059. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AudioStreamandVideoStreamnow deliver every frame that was queued before the stream ended, andVideoStreamiteration now ends at end of stream instead of waiting forever.Problem
__anext__returnedStopAsyncIterationas soon as the stream's internal task finished. The task finishes when the end-of-stream event arrives, so a consumer that was behind the producer lost every frame still in the queue.VideoStream._rundid not enqueue the end marker thatAudioStream._runenqueues. A consumer that was already waiting for a frame when the stream ended stayed blocked.Changes
AudioStream.__anext__andVideoStream.__anext__stop only when the task is done and the queue is empty.VideoStream._runenqueuesNoneon end of stream, matchingAudioStream.RingQueue.empty().tests/rtc/test_stream_end.py. The tests fake the FFI queue, so they need no native library or server.Testing
pytest tests/rtc/test_stream_end.py: 3 tests fail without the source change (two lose frames, one times out waiting for the video stream to end) and pass with it.tests/rtc/test_mixer.py,test_ffi_queue.pyandtest_emitter.pystill pass.