Repository navigation
Conversation
The first refresh request schedules the update 20 s later, and requests that arrive while it is pending join it without moving the deadline. When BG or device status is polled every 5 or 10 s, the snapshot is still saved and the Live Activity updated within 20 s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Live Activity refresh was debounced by 20 s, and every new request restarted the timer. When a reading is late, BG is fetched every 5 s and device status every 10 s, so the timer never fired and the Live Activity and the saved snapshot stayed stale until polling slowed down. This also happens in a normal loop cycle while waiting for the loop to upload device status after a new BG.
Now the first request schedules the refresh and later requests join it, so the update runs within 20 s regardless of how often data is fetched. The existing check that skips unchanged snapshots is the same. Added unit tests for the new RefreshCoalescer.