Repository navigation
Conversation
The left column and the metric grid used fixed minimum widths that needed about 369 pt, so with Display Zoom the card was wider than the lock screen and the glucose value and delta got cut off. They now share the available width, and the metric blocks shrink below 72 pt when needed. Fixes #744
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #744.
The lock screen card had fixed minimum widths (160 pt left column, 72 pt per metric) that added up to about 369 pt. With Display Zoom the lock screen is narrower than that, so the card overflowed and the glucose value and delta were cut off on the left. The left column and the metric grid now share the width, and the metric blocks can shrink below 72 pt. On wider phones the card looks about the same as before.