Repository navigation
[dv] Fix riscv_rf_addr_intg_test spurious failures - #2526
Open
SamuelRiedel wants to merge 1 commit into
Open
SamuelRiedel wants to merge 1 commit into
SamuelRiedel wants to merge 1 commit into
Conversation
The test glitches a regfile read address and expects an ECC error. But the ECC check only fails if the original and glitched registers hold different data. Previously, the test injected the fault blindly and if the two registers happened to hold the same value, no ECC error would occur and the test reported a fatal failure. Fix by snooping the register file contents before injecting the fault and retrying until the original and glitched registers hold distinct data. Signed-off-by: Samuel Riedel <[email protected]>
SamuelRiedel
requested review from
gautschimi,
hcallahan-lowrisc,
henrikpedersen-oss and
nasahlpa
October 7, 2026 12:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test glitches a regfile read address and expects an ECC error. But the ECC check only fails if the original and glitched registers hold different data. Previously, the test injected the fault blindly and if the two registers happened to hold the same value, no ECC error would occur and the test reported a fatal failure.
Fix by snooping the register file contents before injecting the fault and retrying until the original and glitched registers hold distinct data.