Repository navigation
[rtl] Qualify CheriotWaddrMSBClear assertion with we_a_i - #2527
Open
SamuelRiedel wants to merge 1 commit into
Open
SamuelRiedel wants to merge 1 commit into
SamuelRiedel wants to merge 1 commit into
Conversation
Signed-off-by: Samuel Riedel <[email protected]>
SamuelRiedel
requested review from
gautschimi,
hcallahan-lowrisc and
henrikpedersen-oss
October 7, 2026 12:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the FFs are not all resettable (
ResetAll == 0), therf_waddr_wb_qregister might hold arbitrary data after reset and trigger the assertion checking that in CHERIoT, we only write the lower 16 registers. This fixes this by validating the assertion with the write enable signal.Note,
ResetAllis always set when enablingSecureIbexand thereby in OpenTitan.Fixes https://github.com/lowRISC/earlgrey-internal-tracker/issues/923