Repository navigation
[dv] V1 signoff for SPI Device DV block - #699
Merged
tchilikov-semify merged 1 commit intoOct 16, 2026
Merged
Conversation
tchilikov-semify
force-pushed
the
spi_device_signoff
branch
from
August 27, 2026 11:23
7617668 to
73fffe0
Compare
tchilikov-semify
force-pushed
the
spi_device_signoff
branch
from
September 29, 2026 09:21
73fffe0 to
be6a997
Compare
marnovandermaas
left a comment
marnovandermaas
left a comment
Collaborator
There was a problem hiding this comment.
One comment from my end.
tchilikov-semify
force-pushed
the
spi_device_signoff
branch
2 times, most recently
from
September 30, 2026 13:17
1210c07 to
ba7f0cd
Compare
tchilikov-semify
force-pushed
the
spi_device_signoff
branch
from
October 9, 2026 12:39
ba7f0cd to
0e5ae1e
Compare
tchilikov-semify
force-pushed
the
spi_device_signoff
branch
from
October 9, 2026 14:11
0e5ae1e to
227ab85
Compare
marnovandermaas
approved these changes
Oct 9, 2026
marnovandermaas
left a comment
marnovandermaas
left a comment
Collaborator
There was a problem hiding this comment.
One comment from mine should be resolved but otherwise looks good to me. Please also make sure we wait for 3 approvers before merging.
Contributor
|
@marnovandermaas, we'll need a 3rd approver. Do you have anybody in your mind? |
tchilikov-semify
force-pushed
the
spi_device_signoff
branch
from
October 13, 2026 09:05
227ab85 to
6762a60
Compare
Collaborator
|
I'll ask @KinzaQamar to help. |
KinzaQamar
reviewed
Oct 15, 2026
KinzaQamar
approved these changes
Oct 16, 2026
KinzaQamar
left a comment
KinzaQamar
left a comment
Contributor
There was a problem hiding this comment.
You beat me replying here. Yes, I later realized 2p means 2 port.
Thanks for your PR, LGTM.
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 16, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is intended to sign off the SPI Device DV to V1
Closes Issue #162