Repository navigation
[dv,kmac] add a top-level KMAC smoke test - #701
Merged
Merged
Conversation
tchilikov-semify
force-pushed
the
kmac_dv
branch
from
August 27, 2026 11:42
21cab26 to
3c97b47
Compare
tchilikov-semify
marked this pull request as ready for review
August 27, 2026 11:43
tchilikov-semify
force-pushed
the
kmac_dv
branch
from
August 28, 2026 12:06
3c97b47 to
77ca997
Compare
martin-velay
approved these changes
Oct 8, 2026
martin-velay
left a comment
martin-velay
left a comment
Contributor
There was a problem hiding this comment.
You've addressed all my previous comments, thanks. Can you just rebase and resolve the sw/device/tests/CMakeLists.txt:22 conflicts with main?
tchilikov-semify
force-pushed
the
kmac_dv
branch
from
October 8, 2026 13:30
77ca997 to
8d631da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a software top level KMAC smoke test, which compares the hash of the ROM to the expected hash, and observes a CPU boot.