Repository navigation
test: consolidate named tests into the property suites - #287
Merged
Merged
Conversation
Retire the example tests whose behavior the jetCheck suites already check over generated input: - Hrana JSON: the differential property exercises both codec implementations, and the decode example was identical in both codec tests. Strengthen the property to assert the whole response (baton, cols, last_insert_rowid), not just the first value. - SqlScript: the script generator now includes empty, whitespace and comment-only statements, BEGIN/COMMIT, and unterminated quotes, so the named splitter examples add nothing. - getBoolean: two tests were strict subsets of the parameterized storage-class case. Net -198 lines in the unit lane (13402 -> 13204).
magnusp
force-pushed
the
test/consolidate-property-covered-tests
branch
from
October 31, 2026 17:41
e81ccb5 to
425d53b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The property pilot left several named tests that the generated suites now cover. Remove those and strengthen the generators where a named case was not yet modeled.
JacksonHranaJsonCodecTestand the duplicate decode example inDirectHranaJsonCodecTest.HranaJsonCodecPropertyTestalready runs both codecs; it now also asserts the whole response (baton,cols,last_insert_rowid).SqlScriptTest. The generator now includes empty, whitespace and comment-only statements,BEGIN/COMMIT, plus a property that an unterminated quote stays inside one statement.Net: -198 lines in the non-container unit lane (13,402 -> 13,204) and -11 tests.
Most of the remaining suite stays: it asserts wire-level protocol behavior and the Appendix B matrix, which properties cannot replace. The larger conversions (generated-key classifier, wire-level lifecycle model, Appendix B value matrix) are listed as follow-ups in
docs/property-based-testing.md.Type of Change
Checklist
./mvnw spotless:check)../mvnw clean verify).