Repository navigation
chore(ci): use setup-java env-var inputs for Maven credentials - #454
Merged
Merged
Conversation
actions/setup-java v6 deprecated server-username, server-password and gpg-passphrase in favor of the -env-var variants. The release run for v0.0.22 warned about each one. Rename them in the release and snapshot workflows. The new inputs take the same environment variable names, so the generated settings.xml stays the same. Co-authored-by: Claude Opus 5.5 <[email protected]> Signed-off-by: Marc Nuri <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/setup-java@v6has deprecated theserver-username,server-passwordandgpg-passphraseinputs. Itsaction.ymlnow calls them "Deprecated alias for …-env-var". The v0.0.22 release run (41277699804) logged a warning for each of them:This PR renames the three inputs to
server-username-env-var,server-password-env-varandgpg-passphrase-env-varin:.github/workflows/release.yml.github/workflows/snapshots.ymlThe values stay the same: the names of the environment variables (
MAVEN_CENTRAL_USERNAME,MAVEN_CENTRAL_PASSWORD,SIGNINGPASSWORD) that the deploy step sets from secrets. setup-java still writes them tosettings.xmlas${env.X}placeholders, so publishing to Central works the same way.Testing
The PR build does not run either changed workflow. After merge, the nightly
snapshots.ymlrun (cron 02:00 UTC, or a manualworkflow_dispatch) will confirm the change before the next release. Look for the deprecation warnings to be gone and for the snapshot deploy to authenticate and sign as before.