Repository navigation
TestPurgeRemovesGivenUpDelivery: age the rows, don't race the clock - #63
Merged
Merged
Conversation
The test used a 0.2s retry window, so on a slow runner the setup before the first check outlasted it and the in-window delivery was purged (seen in CI). It now uses an hour's window and moves time_sent and time_added back two hours, with triggers off, to step past it. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestPurgeRemovesGivenUpDeliverywas flaky. It setRetryMaxAge = 0.2and expected the first message to still be inside the window after a second send, an add-to and several updates. On a slow runner that took longer than 0.2s, so the delivery had already aged out and was purged (delivery still in the retry window removed, seen in fmsgAI CI).It now uses a one-hour window and steps past it with a new
ageByhelper. The helper moves the message'stime_sentand its add-to batches'time_addedback two hours, with triggers off (session_replication_role = replica), becausetime_sentis immutable once sent. The sleep is gone.Checks, against local Postgres 17:
Test-only change.
🤖 Generated with Claude Code