Repository navigation
Fix form parsing, browser exports, and test coverage - #121
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 29 files
Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack
View guided diff | Turn on auto-fix | Re-trigger cubic
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Path-derived keys were rebuilt and stored for every indexed segment, so deeply nested indexes took quadratic time and memory and could exhaust the heap on a single long field name. Key each index map by the array it belongs to instead, which keeps MergeContext's public shape unchanged. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Keep distinct indexed paths such as
a.b.c[0].xandab.c[0].yisolated, honor custom delimiters and deeply nested arrays when filling forms, and point standalone browser exports at the emitted bundles. Exclude nested worktrees from integration test discovery.Use linear bracket scanning on malformed names and simplify adapter forwarding. Remove redundant flattening copies, unused themes, and unused result panels. Remove manual dependency/version assertions and replace source-text assertions with rendered browser checks. Add regressions that execute the published standalone bundles, fix the mobile divider, and make Playwright own a fresh foreground preview. Include a patch changeset for the fixed package group.
Validation: