Repository navigation
Make LRAUV deployment plotting robust to dods errors and untransferred logs - #211
Merged
Merged
Conversation
…d logs Retry transient dods server errors (502 Bad Gateway, seen as OSError Errno -70/-68) per file. Open and fully load each *_1S.nc inside _open_dataset_with_retry (OPEN_ATTEMPTS tries, growing backoff), so a failure retries only that file and xr.concat makes no network reads. After the last attempt the error is re-raised. Retry the per-log-dir HTTP listings in _nc_files_for_dir (LISTING_ATTEMPTS tries), and record for each log dir whether its listing shows a .nc4. Fix false "still waiting for log dir(s) to finish transferring" warnings that withheld notifications. _pending_log_dirs() now decides on the presence of the .nc4 file, which means the log has been transferred, not on the presence of *_1S.nc. A dir with a .nc4 but no *_1S.nc is not pending; INFO logs say whether it is awaiting processing or failed, with any ERROR lines from its *_processing.log. A dir with no .nc4, or whose listing could not be fetched, stays pending. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry transient dods server errors (502 Bad Gateway, seen as OSError Errno -70/-68) per file. Open and fully load each *_1S.nc inside _open_dataset_with_retry (OPEN_ATTEMPTS tries, growing backoff), so a failure retries only that file and xr.concat makes no network reads. After the last attempt the error is re-raised.
Retry the per-log-dir HTTP listings in _nc_files_for_dir (LISTING_ATTEMPTS tries), and record for each log dir whether its listing shows a .nc4.
Fix false "still waiting for log dir(s) to finish transferring" warnings that withheld notifications. _pending_log_dirs() now decides on the presence of the .nc4 file, which means the log has been transferred, not on the presence of *_1S.nc. A dir with a .nc4 but no *_1S.nc is not pending; INFO logs say whether it is awaiting processing or failed, with any ERROR lines from its *_processing.log. A dir with no .nc4, or whose listing could not be fetched, stays pending.