Repository navigation
fix(lua): resolve rlocation from the runfiles manifest - #8
Merged
Merged
Conversation
Changes runfiles.rlocation in the RUNFILES_MANIFEST_FILE branch of the binary wrapper to return the manifest entry for _main/<path>, matching the RUNFILES_DIR branch. Extend main_outside_runfiles_test to read a data file through rlocation with a runfiles tree and with only a manifest. Closes #7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
runfiles.rlocationto return the runfiles manifest entry when a binary runs with only a manifest, e.g.bazel-bin/<name>_execon Bazel 9. Closes #7.Click for implementation details
manifest["_main/" .. path]in theRUNFILES_MANIFEST_FILEbranch oflua/private/binary_wrapper.lua, matching theRUNFILES_DIRbranch. A path missing from the manifest returns nil.main_outside_runfiles_testto readdata.txtthroughrlocationwith a runfiles tree and with only a manifest.bazel test //...inexamples/on Bazel 9.3.1 and 8.1.0 (5 tests).