Repository navigation
Add EmergentCamera device adapter - #1032
VolodymyrCherkas wants to merge 3 commits into
Conversation
|
Thanks for the PR! Can you remove all binaries (they don't belong in the repo) and duplicate licenses, as well as CMake files (which we don't use)? Also remove the .gitattributes file; we handle newlines by using the default Git for Windows settings which work without this (LF in the repo, CRLF in worktree text files on Windows). Why are test results saved in the tree? Are the tests testing the SDK or the adapter or both? The Windows run-tests.ps1 hard-codes various paths. This suggests that it is for your dev env, not something appropriate for this shared repo. What are the INI files for? Are they something the camera vendor requires to operate the device? If not, it would seem like something the application layer should handle and not be part of a device adapter. Statements like "The adapter directory was renamed from Could you (not (just) your LLM) go through and review all the files and make sure that they are aimed at a human reader and are set up for maintenance over time and also do not include any unnecessary/excessive material? Then I'll be happy to actually review the code and build files. |
|
Dear Mark, thank you very much for your constructive feedback! I have cleaned it up, removed .ini configurations, recompiled and tested it is operational under Windows 11. I have checked it after the LLM and it looks much cleaner now. |
Adds an eSDK-based adapter for Emergent monochrome GigE cameras. It supports camera discovery, Snap/Live/sequences, hardware ROI/binning, Mono8/10/12, exposure/gain controls, trigger/GPIO configuration and PTP.
The adapter exposes camera parameters as Micro-Manager properties.
Build and dependencies
The change is confined to
DeviceAdapters/EmergentCamera/: two C++ implementation files, one header, the Windows Visual Studio project/filter files and one BSD-3-Clause license. Emergent SDK headers and libraries must be installed separately from the manufacturer.For Windows x64, use Visual Studio 2022/v143 C++ tools. From the
mmCoreAndDevicesroot:The configurable
ESDK_ROOTproperty defaults to the vendor installation directory,C:\Program Files\EVT\eSDK. Repository-wide build registration is outside this adapter-only change.Validation