Skip to content

Harden DT PR runs - #1350

Merged
Jake Bailey (jakebailey) merged 3 commits into
microsoft:mainfrom
jakebailey:harden-pipeline-boundaries
Oct 20, 2026
Merged

Jake Bailey (jakebailey) merged 3 commits into
microsoft:mainfrom
jakebailey:harden-pipeline-boundaries

Conversation

@jakebailey

Copy link
Copy Markdown
Member

While we only run tests on trusted PRs, do a bit of work to harden the pipeline against AzDO commands and similar problems.

Compiler diagnostics can include third-party Azure command markers even
inside JSON strings. Restrict custom task commands and variable setters
so those diagnostics cannot acquire general agent authority.

Allow only GH_TOKEN from token creation, while retaining trusted tool
setup and artifact task capabilities and existing formatter escaping.
Restricted Azure commands still permit successful early task completion.
Validate every expected main and PR shard in an independent trusted task
before creating posting credentials for successful runs. Share the shard
count with the parallel job configuration and revalidate before posting.

Require regular files containing failure arrays with string paths and
errors, while accepting empty clean shards and preserving diagnostics.
Keep validation errors fixed so malformed artifacts cannot inject agent
commands through parser or filesystem errors. Preserve failure reports
without requiring successful-run artifacts.
@jakebailey
Jake Bailey (jakebailey) added this pull request to the merge queue Oct 20, 2026
Merged via the queue into microsoft:main with commit 0b7f683 Oct 20, 2026
9 checks passed
@jakebailey
Jake Bailey (jakebailey) deleted the harden-pipeline-boundaries branch October 20, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants