Repository navigation
[diskann-garnet] Add macOS arm64 support to NuGet publishing - #1495
Open
Jack Moffitt (metajack) wants to merge 1 commit into
Open
Jack Moffitt (metajack) wants to merge 1 commit into
Jack Moffitt (metajack) wants to merge 1 commit into
Conversation
Jack Moffitt (metajack)
requested review from
a team
and
a balanced review from Copilot
October 15, 2026 21:28
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The macOS local-packaging instructions still use a Linux-only copy command.
1 open finding
What changed in this PR
Adds macOS ARM64 native libraries to the diskann-garnet NuGet publishing pipeline.
Changes:
- Builds and stages the macOS library with platform-specific Rust flags.
- Packages the
osx-arm64asset and verifies native package contents. - Updates installation and local packaging documentation.
| File | Description |
|---|---|
| diskann-garnet/README.md | Documents supported platforms and packaging steps. |
| diskann-garnet/diskann-garnet.nuspec | Includes the macOS ARM64 native library. |
| .github/workflows/publish-diskann-garnet-nuget.yml | Builds, stages, and verifies macOS assets. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Jack Moffitt (metajack)
force-pushed
the
garnet-macos-arm64
branch
from
October 15, 2026 21:35
9cdfe75 to
3789e34
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1495 +/- ##
==========================================
+ Coverage 91.03% 92.07% +1.03%
==========================================
Files 586 586
Lines 119926 119926
==========================================
+ Hits 109176 110417 +1241
+ Misses 10750 9509 -1241
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Jack Moffitt (metajack)
force-pushed
the
garnet-macos-arm64
branch
from
October 16, 2026 12:06
3789e34 to
793b673
Compare
Mark Hildebrand (hildebrandmw)
approved these changes
Oct 16, 2026
Harsha Simhadri (harsha-simhadri)
approved these changes
Oct 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds macos-arm64 to the publishing targets for the diskann-garnet NuGet.