Repository navigation
Fix/xxe xinclude detection - #3429
Merged
Richard Lundeen (richlundeen) merged 4 commits intoOct 25, 2026
Merged
Richard Lundeen (richlundeen) merged 4 commits into
Richard Lundeen (richlundeen) merged 4 commits into
Conversation
Richard Lundeen (richlundeen)
left a comment
Contributor
There was a problem hiding this comment.
This pattern is broader than XInclude. It matches an ordinary <include href="https://example.com/help.xml" /> with no XInclude namespace, and it also matches <xi:include data-href="https://example.com/help.xml" /> even though that element has no href attribute. Both now count as successful XXE output.
Please narrow the match and add these negative cases. If recognizing XInclude correctly needs substantially more XML parsing machinery, I would rather close this small extension than add that complexity to a regex scorer.
Reviewed with GitHub Copilot.
Require an exact href attribute and avoid matching ordinary include elements. Cover conventional xi prefixes and explicit default XInclude namespaces. Co-authored-by: Copilot App <[email protected]>
Richard Lundeen (richlundeen)
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tests and Documentation
Summary
Adds XXE output detection for XML XInclude elements that reference external resources.
Changes
hrefvalues usingfile:,http:,https:, orftp:schemes.Testing
includeelements.Scope
This change addresses the XInclude detection gap discussed in #3324. It complements existing XXE-related coverage without changing unrelated detection behavior.