Repository navigation
FIX: map canonical harm categories in get_all_harm_metrics - #3543
Merged
Roman Lutz (romanlutz) merged 2 commits intoOct 27, 2026
Merged
Roman Lutz (romanlutz) merged 2 commits into
Roman Lutz (romanlutz) merged 2 commits into
Conversation
Roman Lutz (romanlutz)
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_all_harm_metrics built the file name straight from the category, so SEXUAL_CONTENT and REPRESENTATIONAL, the names those scorers actually use, pointed at files that don't exist and came back empty. Both lookups now go through the same helper as find_harm_metrics_by_eval_hash. The new tests check both read the same file and that the scorer categories find real registry entries, and they fail on main.
Fixes #3542