Repository navigation
FIX: sample within word punctuation insertion from every position - #3566
Open
Manohar Paturi (ManoharPaturi) wants to merge 4 commits into
Open
Manohar Paturi (ManoharPaturi) wants to merge 4 commits into
Manohar Paturi (ManoharPaturi) wants to merge 4 commits into
Conversation
Roman Lutz (romanlutz)
approved these changes
Oct 28, 2026
Roman Lutz (romanlutz)
approved these changes
Oct 28, 2026
Contributor
Author
|
Neither of the red checks touches this change's code path: the PR modifies one Python converter, and the failures were the frontend unit coverage job and the shared coverage job. This push merges current main, which also brings the branch back up to date, so both re-run. The converter suites still pass locally (24 and 249 tests). |
Manohar Paturi (ManoharPaturi)
requested a review
from Roman Lutz (romanlutz)
October 28, 2026 14:02
Remove the unreachable insertion fallback and exercise insertion boundaries deterministically. Wait for modal accessibility restoration before reopening the run preview. Co-authored-by: Copilot App <[email protected]>
Contributor
|
Yes, don't worry Manohar Paturi (@ManoharPaturi) I will take care of it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the linked issue
The insertion index sample drew from
range(len minus 1), so punctuation could never land immediately before the last character or after the final character of the prompt. The sample now draws fromrange(len + 1), the full set of insertion points of an n character list, and the too few characters fallback inserts at the end of the prompt.Tests and Documentation
Added a reachability regression test that converts the prompt
abcacross 200 seeds and asserts all four insertion offsets appear. It fails on main, where only offsets 0 and 1 ever appear, and passes with the change. The full converter suite passes (24 tests).No documentation change needed, so I did not run JupyText.