Repository navigation
FIX: clear conversation panel state when switching attacks - #3576
Open
Manohar Paturi (ManoharPaturi) wants to merge 2 commits into
Open
Manohar Paturi (ManoharPaturi) wants to merge 2 commits into
Manohar Paturi (ManoharPaturi) wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3575
The render phase reset only cleared the conversation list when the new attack id was null, so switching between two attacks left the previous attack's conversations clickable under the new attack's header until the fetch resolved. The reset now runs for every attack change: it clears the list, main id, and error, and enters the loading state when the new id is present, matching the mount behavior.
Tests and Documentation
Added a regression test that loads one attack's conversations, switches to a second attack whose fetch never resolves, and asserts the old row is gone and the new fetch was requested. It fails on main and passes with the change. The full panel suite passes (17 tests) and tsc is clean.
No documentation change needed, so I did not run JupyText.