Repository navigation
FEAT: Browse Scenario result parents and children in the GUI (#3602) - #3611
Open
Fazeel Usmani (FazeelUsmani) wants to merge 1 commit into
Open
Fazeel Usmani (FazeelUsmani) wants to merge 1 commit into
Fazeel Usmani (FazeelUsmani) wants to merge 1 commit into
Conversation
…ft#3602) Add a read-only "Result hierarchy" section to the Scenario run page, built on the hierarchy endpoints from microsoft#3167. Roots load in pages with the root cursor. Expanding a result loads its saved children in pages with that node's own children cursor, so the two never mix. Children are shown at their absolute position under the parent, and missing, duplicate or cyclic references stay visible in place as unresolved. Run and group totals are shown exactly as the backend reports them and are never counted from loaded rows. Rootless results are reported, not turned into roots. A stale cursor (HTTP 400) shows a reload action instead of a generic error. Details reuse the existing attempt dialog, and fall back to the clicked node when the progress feed has not delivered that result yet. Tests: unit tests for child positions and root merging, component tests for paging, stale cursors, reloads, totals and empty/truncated/rootless states, and a Playwright suite against a seeded backend (playwright.scenario-hierarchy.config.ts), added to the CI matrix.
Author
|
@microsoft-github-policy-service agree |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3602 (scope 10A). Adds a read-only "Result hierarchy" section to the Scenario run page, using the endpoints from #3167. No backend changes.
children_cursor.Transcript/conversation evidence (scope 10B) is out of scope.
Side note, not changed here: run-level
retriescounts each child of a compound attack as a re-attempt of the parent's unit (retry_pressureinpyrit/analytics/scenario_statistics.py), so a 520-step Sequential run shows "Retries: 520". Happy to open an issue if that isn't intended.Tests and Documentation
playwright.scenario-hierarchy.config.ts), added to the CI matrix. It pages a 520-child Sequential parent, checks unresolved positions, stable totals, keyboard use, and a 390px layout.pyrit/backend/README.md, which said the GUI still shows flat executions.Locally:
tsc,eslint, Jest and the new Playwright suite pass (twoScenarioDetailtests fail the same way onmain).Screenshots below.
