Repository navigation
fix(zod): parenthesize optional and multi-value literal types in schema text - #445
Open
Mohammed Alkindi (MohammedAlkindi) wants to merge 1 commit into
Open
Mohammed Alkindi (MohammedAlkindi) wants to merge 1 commit into
Mohammed Alkindi (MohammedAlkindi) wants to merge 1 commit into
Conversation
…ma text
z.array(z.literal(['a', 'b'])) was emitted as "a" | "b"[], which TypeScript reads as "a" | ("b"[]). Optional types and multi-value literals are emitted as unions, so they now get union precedence and are parenthesized in array, intersection and tuple positions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getZodSchemaAsTypeScriptemits optional types asT | undefinedand multi-value literals as a union of their values, but gave both object precedence, so they lost their parentheses. Onmain:The last two are not valid TypeScript, and the others describe a different type than the schema.
getTypePrecedencenow gives both union precedence. Single-value literals are unchanged.npm testintypescript/: 121 pass. Six of the eight new tests fail onmain; the other two check that single literals and union members stay unparenthesized.