fix(64494): fix decorated class names with private member self-references - #64505
Open
Oleksandr Tarasiuk (a-tarasyuk) wants to merge 5 commits into
Open
Oleksandr Tarasiuk (a-tarasyuk) wants to merge 5 commits into
Oleksandr Tarasiuk (a-tarasyuk) wants to merge 5 commits into
Conversation
typescript-automation
Bot
added
For Uncommitted Bug
Contributor
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Copilot started reviewing on behalf of
Oleksandr Tarasiuk (a-tarasyuk)
September 28, 2026 17:02
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The incorrect temporary-derived class name remains possible when pending expressions exist without transformable statics.
Review effort: Balanced
Findings: 1
What changed in this PR
Fixes decorated class naming when private members reference their enclosing class.
Changes:
- Avoids unnecessary temporary assignment for affected decorated classes.
- Adds coverage for private fields, methods, getters, and setters.
| File | Description |
|---|---|
tsc/internal/transformers/estransforms/classfields.go |
Adjusts decorated class-expression emission. |
tsc/testdata/tests/cases/conformance/esDecorators/classDeclaration/esDecorators-classDeclaration-setFunctionName.ts |
Adds regression cases. |
tsc/testdata/baselines/reference/conformance/esDecorators-classDeclaration-setFunctionName(target=esnext).js |
Updates ESNext baseline. |
tsc/testdata/baselines/reference/conformance/esDecorators-classDeclaration-setFunctionName(target=es2022).js |
Updates ES2022 baseline. |
tsc/testdata/baselines/reference/conformance/esDecorators-classDeclaration-setFunctionName(target=es2015).js |
Updates ES2015 baseline. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Oleksandr Tarasiuk (a-tarasyuk)
marked this pull request as draft
September 28, 2026 17:07
Oleksandr Tarasiuk (a-tarasyuk)
marked this pull request as ready for review
September 28, 2026 17:17
Copilot started reviewing on behalf of
Oleksandr Tarasiuk (a-tarasyuk)
September 29, 2026 06:55
View session
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64494