check intersection props for never-reduction in a stable order - #64521
Draft
Max Schwenk (maschwenk) wants to merge 1 commit into
Draft
Max Schwenk (maschwenk) wants to merge 1 commit into
Max Schwenk (maschwenk) wants to merge 1 commit into
Conversation
somePropertyReducesToNever ranged over a map, so the combined properties it creates were created in a random order, and when there was more than one candidate, which of them got created before it returned varied between runs. Keep the counts in an OrderedMap so the properties are checked in the order they were found. Co-Authored-By: Claude Opus 5.5 <[email protected]>
typescript-automation
Bot
added
the
For Uncommitted Bug
6 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to:
somePropertyReducesToNeverranges over a map, so the order it builds the combined properties in is random. when an intersection has more than one candidate, which ones get built before it returns changes from run to run, so the same program does slightly different work each timeon vscode from typescript-benchmarking with
--singleThreaded, the symbol count comes out 8557485 / 8557513 / 8557486 on main, and 8557373 every time with this. before that PR it was stable toodiagnostics were the same in everything i ran (the 6 typescript-benchmarking tsc projects give the same output with and without this), but different work run to run is how order dependent output sneaks in, and it makes perf comparisons noisy
this keeps the counts in a
collections.OrderedMapso the names are checked in the order they were foundgo test ./...intsc), exceptTestFSEventsWatchFileDifferentCasing, a macOS file watcher test that fails for me under load and passes on its ownhereby linthereby check:formatused claude code to help write this, ive reviewed it