Skip to content

feat: [5/6] add reserved payload cleanup worker tasks - #392

Open
wangbill (YunchuWang) wants to merge 7 commits into
yunchuwang-payload-phase-4-clientfrom
yunchuwang-payload-phase-5-worker
Open

wangbill (YunchuWang) wants to merge 7 commits into
yunchuwang-payload-phase-4-clientfrom
yunchuwang-payload-phase-5-worker

Conversation

@YunchuWang

@YunchuWang wangbill (YunchuWang) commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Summary

What changed?

  • Add worker-only cleanup orchestration and reserved fetch/delete/report activities while keeping phase 4 DTOs independent of the runner.
  • Retain the original state machine: five-cycle continue-as-new, delivered/buffered configuration draining, interruptible durable idle, unsupported-backend waiting and bounded retry policy.
  • Delete chunks of 50 with four activity waves and eight concurrent deletes per chunk, preserve positional tombstone correlation, classify terminal/retry/quarantined results safely and enforce RPC/store deadlines.
  • Register reserved tasks only for payload-enabled workers, augment nonempty filters with wildcard versions, bypass business version policy for internal tasks and reuse the current authenticated channel.
  • Carry original cleanup worker tests and an isolated loopback test that additionally verifies fetch/report follow a replacement effective sidecar stub.

Why is this change needed?

  • Phase 5/6 of the requested large-payload implementation split. This PR's base is phase 4's branch, so its diff excludes previously reviewed phases.
  • Behavioral reference: durabletask-dotnet 91739687. The stack also inherits the reviewed JavaScript carryover and whole-message size-preflight repairs described below; it does not claim unchanged .NET failure-priority semantics.

Issues / work items

  • Resolves: N/A (user-requested phased feature review).
  • Related: original oversized PR #387. It is closed without merging; its original branch/history remain preserved.

Project checklist

  • Release notes are not required for the next release
    • Otherwise: Notes added to CHANGELOG.md
  • Backport is not required
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • All required tests have been added/updated (unit tests, E2E tests)
  • Breaking change?
    • If yes:
      • Impact: No intentional API break in this phase; the payload feature remains opt-in.
      • Migration guidance: Do not release partial phases. Merge the stack in order and publish the completed core before dependent packages.

AI-assisted code disclosure (required)

Was an AI tool used? (select one)

  • No
  • Yes, AI helped write parts of this PR (e.g., GitHub Copilot)
  • Yes, an AI agent generated most of this PR

If AI was used:

  • Tool(s): GitHub Copilot.
  • AI-assisted areas/files: This phase's source, regression tests, and directly related metadata/documentation.
  • What you changed after AI output: Split the implementation along independently buildable boundaries; retained focused regression evidence and removed unrelated formatting-only changes. Human review is still required.

AI verification (required if AI was used):

  • I understand the code and can explain it
  • I verified referenced APIs/types exist and are correct
  • I reviewed edge cases/failure paths (timeouts, retries, cancellation, exceptions)
  • I reviewed concurrency/async behavior
  • I checked for unintended breaking or behavior changes

These human attestations are intentionally left unchecked.


Testing

Automated tests

  • Current review head: 20ee1eb59e08ceac1a23d7b8cd42670e32041aa0.
  • This merge hop used exact approved source/test blob, ancestry and stable-patch checks, commit-hook ESLint and whitespace checks. No redundant phase-local transport suite or all-workspace build is claimed.
  • Shared-call owning evidence is pinned to PR389 f3ea69fc79eb594961ab4d57651f5e1360fb9127: 233 tests / 8 suites plus core build/lint passed.
  • Runner lifecycle owning evidence is pinned to PR391 7c9d67f97c961c148a5fdd4809e7443c268d7162: 45 tests / 2 suites plus core build/lint passed; this phase inherits that exact client and lifecycle fixture.
  • git diff --check origin/yunchuwang-payload-phase-4-client...HEAD — passed. Prior heads remain ancestors; predecessor bases, phase-local review scopes, release/cleanup/version notes and ready-for-review state are preserved.
  • Combined final on exact ae63cab8ecb6ec6b2b3e0e15067091a5b8a6b24e: npm run test:unit — 3,180 tests / 133 suites passed (core 2,028; Functions 226; Blob 39; Azure-managed 821; export-history 66). Ten opt-in service tests are skipped by this unit command.
  • On the same final head, npm run build passed all five workspaces and npm run lint passed. This is the true final aggregate containing both approved commits; the earlier stopped pre-lifecycle run is not a final pass.
  • Final structural/blob audit passed: one unary transport site and one upload/resolve site in _call; all five semantic callers delegate; phase4–6 client/lifecycle fixtures match the approved runner fix, and PR1 processor plus existing public-loopback fixtures are unchanged.
  • Final DTS live run: 39837123528 on exact ae63cab8ecb6ec6b2b3e0e15067091a5b8a6b24e — PENDING (in_progress) at 2026-10-22T19:07:38.5343134Z. The link is authoritative for later completion; no early pass is claimed.
  • PR388 source/body remain unchanged at 137bb547e8781fd84c2738c3e13ae0f65cd66174; its separately verified hosted evidence is 30 SUCCESS / 1 SKIPPED. Review approval is still required. Main-base-only PR filters are unchanged; absent stacked-PR jobs are not passes.
  • Scope limits remain: no live storage-outage or mixed .NET/JavaScript execution, no transactional rollback or generic orphan collector. Tombstone cleanup cannot discover blobs without a backend-recorded reference.

Manual validation (only if runtime/behavior changed)

  • Environment (OS, Node.js version, components): Windows, Node.js v24.14.0; loopback gRPC with deadlines/metadata and effective-stub replacement assertions; deterministic generator/replay tests.
  • Steps + observed results:
    1. Materialized this phase on its declared predecessor, with no future-phase imports.
    2. Ran the exact owning checks above and inspected the incremental patch.
    3. Kept the original feature branch/history and primary user checkout unchanged.
  • Evidence (optional): Full local logs are session artifacts, not repository changes.

Notes for reviewers

Shared unary boundary correction

  • f3ea69fc79eb594961ab4d57651f5e1360fb9127 restores one private _call pipeline: combine cancellation once; externalize once; generate fresh metadata outside each RPC catch; invoke only the operation's RPC policy; hydrate once after success. true retries the RPC, false rethrows unchanged, and throwing maps a genuine RPC error with its cause. The no-metadata path preserves its original dispatch timing.
  • Scheduling and completion waits no longer inline separate pipelines; rewind/restart mappings use the same RPC-only boundary. Errors are not mutated or tagged and no public API, helper signature, dependency or middleware framework was added.
  • 7c9d67f97c961c148a5fdd4809e7443c268d7162 handles runner dedupe through a per-invocation BUSINESS runnerAlreadyExists outcome set only inside that RPC policy. It is not an error tag or global marker; matching storage/metadata codes or semantic classes remain original failures, and cancellation takes precedence.
  • All earlier reviewed carryover, UTF-8 preflight, token/cancellation, rewind mapping and worker-release repairs remain ancestors. No PR merge, package publication or history rewrite was performed.
Merge order Phase PR Base branch
1 Core contracts #388 main
2 SDK integration #389 yunchuwang-payload-phase-1-core
3 Azure Blob provider #390 yunchuwang-payload-phase-2-sdk
4 Purge protocol/client #391 yunchuwang-payload-phase-3-blob
5 Purge worker #392 yunchuwang-payload-phase-4-client
6 Release/usage/consumers #393 yunchuwang-payload-phase-5-worker

Merge 1 → 2 → 3 → 4 → 5 → 6. Each PR targets its predecessor; retarget the next PR only after its prerequisite merges. Do not publish packages or describe a partial phase as the complete feature.

  • The runtime is now feature-complete, but package publishing and final aggregate usage/consumer checks remain explicitly gated on phase 6.
  • Internal JSON retains the pinned .NET PascalCase shapes. The runner import was separated from client DTOs without changing replay actions.
  • Ownership proof and ETag checks remain in the phase 3 provider; this phase owns backend-safe outcome classification and scheduling.
  • Full live DTS/mixed-.NET execution has not been run locally (Docker daemon unavailable). The final phase records aggregate local Blob/Azurite, source/wire interoperability and packed-consumer evidence without claiming absent hosted checks.

Phase 5 of 6: preserve the .NET-aligned cleanup state machine in a worker-only module, register reserved tasks and wildcard filters, and reuse the current authenticated channel. Carry bounded deletion, retry/quarantine, deadline, batching, configuration and continue-as-new regressions.

Co-authored-by: Copilot App <[email protected]>
Copilot-Session: 81e20512-d3a2-4f8e-a574-f396140ec9c7
wangbill (YunchuWang) and others added 6 commits October 19, 2026 12:55
Propagate native carryover traversal, whole-message size preflight and accurate provider cleanup limitations while preserving worker state-machine behavior and the stacked PR base.

Co-authored-by: Copilot App <[email protected]>
Copilot-Session: 81e20512-d3a2-4f8e-a574-f396140ec9c7
Preserve reserved cleanup registration, current transport, filter and version exclusions while inheriting work-item abandonment and completion-wait RPC deadline isolation.

Co-authored-by: Copilot App <[email protected]>
Copilot-Session: 81e20512-d3a2-4f8e-a574-f396140ec9c7
Preserve the existing phase head and all approved SDK repairs while inheriting aeb598f recognized-token skipping and bee1313 aborted-signal precedence. No unrelated behavior or release metadata changes.

Co-authored-by: Copilot App <[email protected]>
Copilot-Session: 81e20512-d3a2-4f8e-a574-f396140ec9c7
Inherit only the approved rewind mapping and scheduling RPC error-domain repairs, preserving phase-specific lifecycle/routing/cleanup behavior and both directly related notes. Exact approved source/test blobs and stable client patch identity verified.

Co-authored-by: Copilot App <[email protected]>
Copilot-Session: 81e20512-d3a2-4f8e-a574-f396140ec9c7
Inherit the exact approved central _call error-domain correction, owning regressions and directly related documentation. Preserve phase-specific lifecycle/routing/cleanup behavior and prior notes/ancestry; source/test patch identity verified without redundant per-hop suites.

Co-authored-by: Copilot App <[email protected]>
Copilot-Session: 81e20512-d3a2-4f8e-a574-f396140ec9c7
Preserve the published shared unary pipeline and cleanup worker behavior while inheriting only the exact approved lifecycle duplicate-runner source boundary and regressions.

Co-authored-by: Copilot App <[email protected]>
Copilot-Session: 81e20512-d3a2-4f8e-a574-f396140ec9c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant