Repository navigation
Conversation
Add untyped FailureInfo to validator results and translation exceptions, preserve custom metadata and the latest useful candidate across repairs, and retain strict parser and cancellation behavior. Add focused regression coverage and document the additive failure-context API. Co-authored-by: Copilot <[email protected]>
Rename the two test methods flagged by the repository spelling check without changing their coverage or behavior. Co-authored-by: Copilot <[email protected]>
Remove the redundant SourceLink.GitHub 8.0.0 reference that overrides SDK-integrated SourceLink and pulls in Microsoft.Build.Tasks.Git 8.0.0. Document the fixed SDK requirement, retain transitive NuGet auditing, and preserve embedded source-debugging metadata. Co-authored-by: Copilot <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to microsoft/TypeChat#457, which addresses microsoft/TypeChat#116 for TypeScript and Python.
FailureInfoto failedResult<T>instances andTypeChatException, keeping rejected output separate from the typed successValue.JsonElement, raw validatorInputText, and original modelResponseText. Honor configured JSON depth, comment, and trailing-comma rules rather than reparsing rejected input with looser settings.Exception.Data[FailureInfo.ExceptionDataKey], then rethrow the original exception. Initial transport failures, cancellation, and programming exceptions remain unchanged.main, with no unmerged PR dependencies.API
FailureInfo.HasValuedistinguishes unavailable data from an explicit null, false, zero, or empty string.WithFailurereturns a shallow copy and preserves existing payloads and custom metadata rather than mutating a reusable validator result.The existing throwing translation API is preserved. Callers can inspect
TypeChatException.Failure;Responsecontinues to expose the original response. Candidate data may precede the latest response text when a repair cannot be parsed.Validation
netstandard2.0and referencing projects built successfully.MaxDepth = 1, disallowed comments, and disallowed trailing commas.dotnet format whitespace --verify-no-changespassed.git diff --checkpassed.SourceLink audit remediation
Commit
0f18283removes the redundant SourceLink.GitHub 8.0.0 package reference that overrode SDK-integrated SourceLink and pulled in the audited Microsoft.Build.Tasks.Git 8.0.0 package (GHSA-23fw-v26w-5fgq). Microsoft recommends serviced SDKs because there is no patched 8.0 NuGet release. The repository now uses SourceLink supplied by .NET SDK 8+, documents the fixed SDK requirement, and keeps transitive NuGet auditing enabled without suppressions.Validation of the remediation:
/warnaserror: 0 warnings and 0 errors.The two prior spell-check findings were corrected in
d1221af. All PR checks now pass on the remediation commit, including both .NET 8 CI build/test matrix jobs, CodeQL, and TypeChat.NET CI.