[python] fix casing enum by iscai-msft · Pull Request #10329 · microsoft/typespec

iscai-msft · 2026-04-09T20:07:18Z

pkg-pr-new · 2026-04-09T20:09:06Z

npm i https://pkg.pr.new/@typespec/http-client-python@10329

commit: 444e93d

github-actions · 2026-04-09T20:11:33Z

All changed packages have been documented.

✅ @typespec/http-client-python

Show changes

`@typespec/http-client-python` - fix ✏️

Preserve underscores before numeric enum segments and acronyms such as A2A without changing numeric identifiers such as int32.

Azure SDK Bot (azure-sdk) · 2026-04-09T20:20:35Z

You can try these changes here

🛝 Playground	🌐 Website	🛝 VSCode Extension

iscai-msft · 2026-04-09T21:54:18Z

Yuchao Yan (@msyyc) I definitely will investigate this more. I think overall I like the new casing for enums better, but I'm going to go through the rest api specs repo to see how many specs would be affected. Also regardless, I think we need some kind of decorator in tcgc that is like "this is the exact client name, don't change casing or anything", what are your thgouths Chenjie Shi (@tadelesh). Something like @clientNameOverride

Chenjie Shi (tadelesh) · 2026-04-10T02:22:43Z

Yuchao Yan (@msyyc) I definitely will investigate this more. I think overall I like the new casing for enums better, but I'm going to go through the rest api specs repo to see how many specs would be affected. Also regardless, I think we need some kind of decorator in tcgc that is like "this is the exact client name, don't change casing or anything", what are your thgouths Chenjie Shi (@tadelesh). Something like @clientNameOverride

We had a issue to track this: Azure/typespec-azure#3607. Let's prioritize it. I don't think we need a new decorator. We could just add a flag to tell if the name has been customized.

microsoft-github-policy-service · 2026-05-11T14:29:57Z

Hi @iscai-msft. Your PR has had no update for 30 days and it is marked as a stale PR. If it is not updated within 30 days, the PR will automatically be closed. If you want to refresh the PR, please remove the stale label.

microsoft-github-policy-service · 2026-06-04T13:39:36Z

Hi @iscai-msft. The PR will be closed since the PR has no update for 28 days. If this is still relevant please reopen.

Preserve enum casing changes and current utility regression tests. Co-authored-by: Copilot App <[email protected]> Copilot-Session: a56d520e-33f1-474a-aa6c-7f8d999656d8

github-actions · 2026-10-26T17:47:35Z

Python emitter diff

Baseline gh:cefb035e7721a6fdcb6de605b5f469b93055a880 vs this PR.

No changes to generated output.

Rendered diff: inline on the run summary, or the emitter-diff-html artifact.

Informational check (eng/emitter-diff); does not block the PR.

Darren Cohen (dargilco) · 2026-10-26T21:13:19Z

FYI Howie Leung (@howieleung)

Keep digits attached to preceding words and restore word boundaries after digits while preserving date separators and short alphanumeric acronyms. Co-authored-by: Copilot App <[email protected]> Copilot-Session: a56d520e-33f1-474a-aa6c-7f8d999656d8

Copilot

🟡 Changes recommended

The shared conversion still introduces unintended underscores in plural-acronym numeric names, changing existing generated Python properties.

1 open issue

Keep numeric suffixes attached to plural acronyms · New

What changed in this PR

This PR addresses #10312 by updating Python emitter name conversion to preserve underscores before date segments and keep acronyms such as A2A intact.

Changes:

Adjusts numeric boundary handling in the shared naming utility.
Adds utility and emitter tests for enum members and numeric property names.
Adds a Python emitter changelog entry.

File	Description
packages/http-client-python/emitter/test/utils.test.ts	Adds numeric boundary and acronym conversion cases.
packages/http-client-python/emitter/test/emitter.test.ts	Checks emitted enum and property names.
packages/http-client-python/emitter/src/utils.ts	Revises digit splitting and preserves numeric separators.
.chronus/changes/python-fixCasingEnum-2026-3-9-16-6-39.md	Documents the naming fix.

_{Review effort: Balanced}

Co-authored-by: Copilot Autofix powered by AI <[email protected]>

Copilot

🟢 Approval recommended

The Python enum naming change has no active review issues.

No open issues 🎉

1 resolved since last review

Keep numeric suffixes attached to plural acronyms

_{Review effort: Balanced}

Yuchao Yan (msyyc) · 2026-10-28T23:46:04Z

Yuchao Yan (Yuchao Yan (@msyyc)) I definitely will investigate this more. I think overall I like the new casing for enums better, but I'm going to go through the rest api specs repo to see how many specs would be affected. Also regardless, I think we need some kind of decorator in tcgc that is like "this is the exact client name, don't change casing or anything", what are your thgouths Chenjie Shi (Chenjie Shi (@tadelesh)). Something like @clientNameOverride

I expect this PR may introduce some breaking changes to enum names, but I believe the improvement is worthwhile because the new enum member name is clearer. To mitigate the impact on legacy enum cases, I will use clientName and exact.

iscai-msft added 2 commits April 9, 2026 16:06

play around with new casing

9dff579

add changeset

02bab07

iscai-msft requested review from Chenxi Jiang (ChenxiJiang333), catalinaperalta, Laia Patiño (laiapat), Laurent Mazuel (lmazuel), Yuchao Yan (msyyc), Swathi Pillalamarri (swathipil), Chenjie Shi (tadelesh) and Timothee Guerin (timotheeguerin) as code owners April 9, 2026 20:07

microsoft-github-policy-service Bot added the emitter:client:python Issue for the Python client emitter: @typespec/http-client-python label Apr 9, 2026

Darren Cohen (dargilco) approved these changes Apr 9, 2026

View reviewed changes

microsoft-github-policy-service Bot added the stale Mark a PR that hasn't been recently updated and will be closed. label May 11, 2026

microsoft-github-policy-service Bot closed this Jun 4, 2026

chore: update PR microsoft#10329 with latest main

f6d9be2

Preserve enum casing changes and current utility regression tests. Co-authored-by: Copilot App <[email protected]> Copilot-Session: a56d520e-33f1-474a-aa6c-7f8d999656d8

iscai-msft reopened this Oct 26, 2026

iscai-msft requested review from Kashif Khan (kashifkhan), Libba Lawrence (l0lawrence), Mark Cowlishaw (markcowl) and Jeff Fisher (xirzec) as code owners October 26, 2026 17:28

microsoft-github-policy-service Bot removed the stale Mark a PR that hasn't been recently updated and will be closed. label Oct 26, 2026

iscai-msft mentioned this pull request Oct 26, 2026

[python] Enum member names drop underscores before date segments #10312

Closed

Darren Cohen (dargilco) approved these changes Oct 26, 2026

View reviewed changes

Copilot AI balanced review requested due to automatic review settings October 27, 2026 17:25

Copilot started reviewing on behalf of iscai-msft October 27, 2026 17:26

View session

Copilot AI reviewed Oct 27, 2026

View reviewed changes

Comment thread packages/http-client-python/emitter/src/utils.ts Resolved

Modify regex to handle plural upper case words with digits

444e93d

Co-authored-by: Copilot Autofix powered by AI <[email protected]>

Copilot AI balanced review requested due to automatic review settings October 28, 2026 18:08

Copilot started reviewing on behalf of iscai-msft October 28, 2026 18:09

View session

Copilot AI reviewed Oct 28, 2026

View reviewed changes

Yuchao Yan (msyyc) approved these changes Oct 28, 2026

View reviewed changes

iscai-msft added this pull request to the merge queue Oct 28, 2026

Merged via the queue into microsoft:main with commit 231125b Oct 29, 2026
37 checks passed

iscai-msft deleted the python/fixCasingEnum branch October 29, 2026 00:26

Conversation

iscai-msft commented Apr 9, 2026

Uh oh!

pkg-pr-new Bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

@typespec/http-client-python - fix ✏️

Uh oh!

Azure SDK Bot (azure-sdk) commented Apr 9, 2026 • edited by azure-sdk-automation Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iscai-msft commented Apr 9, 2026

Uh oh!

Chenjie Shi (tadelesh) commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

microsoft-github-policy-service Bot commented May 11, 2026

Uh oh!

microsoft-github-policy-service Bot commented Jun 4, 2026

Uh oh!

github-actions Bot commented Oct 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Python emitter diff

Uh oh!

Darren Cohen (dargilco) commented Oct 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Yuchao Yan (msyyc) commented Oct 28, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pkg-pr-new Bot commented Apr 9, 2026 •

edited

Loading

github-actions Bot commented Apr 9, 2026 •

edited

Loading

`@typespec/http-client-python` - fix ✏️

Azure SDK Bot (azure-sdk) commented Apr 9, 2026 •

edited by azure-sdk-automation Bot

Loading

Chenjie Shi (tadelesh) commented Apr 10, 2026 •

edited

Loading

github-actions Bot commented Oct 26, 2026 •

edited

Loading