Repository navigation
[http-client-python] Escape generated discriminator string literals - #12341
Closed
Yuchao Yan (msyyc) wants to merge 1 commit into
Closed
Yuchao Yan (msyyc) wants to merge 1 commit into
Yuchao Yan (msyyc) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <[email protected]> Copilot-Session: ecfba725-b27d-416c-95a6-bc48a498ca8f
Yuchao Yan (msyyc)
requested review from
Chenxi Jiang (ChenxiJiang333),
catalinaperalta,
iscai-msft,
Kashif Khan (kashifkhan),
Libba Lawrence (l0lawrence),
Laurent Mazuel (lmazuel),
Mark Cowlishaw (markcowl),
Chenjie Shi (tadelesh),
Timothee Guerin (timotheeguerin) and
Jeff Fisher (xirzec)
as code owners
October 22, 2026 05:09
microsoft-github-policy-service
Bot
added
the
emitter:client:python
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Targeted verification confirms that downstream template formatting still corrupts escaped discriminator values or produces invalid Python.
1 open issue
What changed in this PR
This PR improves Python client generation by serializing specification strings as Python literals rather than manually adding quotes.
Changes:
- Use
repr()for string constants, discriminator declarations, initializers, and template values. - Add regression coverage for special characters and expression-like strings.
- Update quotation-style expectations and add a fix changelog.
| File | Description |
|---|---|
packages/http-client-python/tests/unit/test_typeddict.py |
Adjust expected literal quotation style. |
packages/http-client-python/tests/unit/test_string_literals.py |
Add literal and discriminator regression tests. |
packages/http-client-python/generator/pygen/codegen/serializers/model_serializer.py |
Escape discriminator class arguments and initializers. |
packages/http-client-python/generator/pygen/codegen/models/primitive_types.py |
Serialize string declarations with repr(). |
packages/http-client-python/generator/pygen/codegen/models/model_type.py |
Serialize discriminator template values with repr(). |
.chronus/changes/python-discriminator-string-literals-2026-10-22.md |
Document the Python emitter fix. |
Review effort: Balanced
| } | ||
| if self.discriminator and self.discriminator_value: | ||
| representation[f'"{self.discriminator.wire_name}"'] = f'"{self.discriminator_value}"' | ||
| representation[f'"{self.discriminator.wire_name}"'] = repr(self.discriminator_value) |
|
You can try these changes here
|
Contributor
Python emitter diffBaseline Diff summary: 1174 file(s), +5813 / -5821 Rendered diff: inline on the run summary, or the emitter-diff-html artifact. Informational check (eng/emitter-diff); does not block the PR. |
Yuchao Yan (msyyc)
deleted the
fix/python-discriminator-string-literals
branch
October 22, 2026 05:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.